Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: copy frame urls #1042

Conversation

JFrankfurt
Copy link
Contributor

@JFrankfurt JFrankfurt commented Oct 5, 2024

Screen.Recording.2024-10-09.at.3.18.17.PM.mov

@JFrankfurt JFrankfurt requested a review from a team October 5, 2024 13:50
@JFrankfurt JFrankfurt self-assigned this Oct 5, 2024
Copy link

linear bot commented Oct 5, 2024

Copy link

vercel bot commented Oct 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 4:13pm
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 4:13pm

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Oct 5, 2024

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@0xchiaroscuro
Copy link

0xchiaroscuro commented Oct 8, 2024

copy
Copy icon

and checkmark icon once copied. With the text saying "frame link copied!"
checkmark

@JFrankfurt JFrankfurt merged commit f8118bc into master Oct 10, 2024
8 checks passed
@JFrankfurt JFrankfurt deleted the feature/bapp-652-improvement-copy-frame-urls-from-someones-basename branch October 10, 2024 16:16
kirkas pushed a commit that referenced this pull request Oct 21, 2024
* feat: copy frame urls

* switch order, switch icon

* frame link copied! copy
kirkas pushed a commit that referenced this pull request Oct 21, 2024
* feat: copy frame urls

* switch order, switch icon

* frame link copied! copy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants